Support KDE in no_std - #443
Draft
day01 wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
=======================================
Coverage 95.63% 95.63%
=======================================
Files 68 68
Lines 16121 16121
=======================================
Hits 15417 15417
Misses 704 704 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
day01
marked this pull request as ready for review
August 30, 2026 19:18
day01
marked this pull request as draft
August 30, 2026 19:18
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
KDE is currently gated by
stdbecausekdtreedoes not expose its allocation-backed API inno_stdbuilds. This continues theno_stdwork tracked in #400 and integrates the upstream support from mrhooray/kdtree-rs#92.Changes
kdewithno_std + allocthrough the upstreamkdtreelibmfeaturenum_traits::Floatwhere density calculations need floating-point methods withoutstdkdtree::withinresult orderingkde_pdfandknn_pdfin the existingno_stdWasm runtime testno_stdfeature combinationBlocked by